Add GRPC Reflection service #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @whs! What do you think about this PR? |
|
Hi, Sorry I didn't have time to review this yet. Generally the idea of adding reflection is ok to me, but may need a security consideration aspect. If I have time I'll review this PR in more details Thank your for the pull request |
suparitlmwn
reviewed
Jan 22, 2025
main.go
Outdated
| @@ -76,6 +77,7 @@ func main() { | |||
| }() | |||
|
|
|||
| grpc_health_v1.RegisterHealthServer(grpcServer, healthServer) | |||
| reflectionservice.Register(grpcServer) | |||
There was a problem hiding this comment.
Can we have option to switch this on/off and default to off so the behavior is still the same? Environment variable should be perfect choice.
There was a problem hiding this comment.
Good idea! What do you think about ENABLE_GRPC_REFLECTION env variable? Added commit with env check
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that adds GRPC reflection support.
Makes it easier to use tools like Postman or grpcurl to see what APIs server exposes and to call them.
I know that the state can be seen using port 9000, but it's easier to explain what XDS server does to others by showing exact XDS APIs that are exposed, otherwise it's a little bit of a blackbox and requires proto files to call it.